-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new expandable component #4847
new expandable component #4847
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…abs/docs.getdbt.com into mwong-expandable-component
adding the add'l orange arrow color requested in the asana ticket: and loom explaining here: https://www.loom.com/share/6ce68b13f2eb49b4b899dfd38ce6c3b3?sid=ccfb843d-0020-424c-9807-a38d6f734fa6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @mirnawong1! Just have a few small requested edits and left comments in those sections. Let me know if you have any questions with those!
:local(.body) { | ||
margin-top: 10px; | ||
margin-left: 1em; | ||
padding: 10px; | ||
background-color: transparent; /* Changed from a color to transparent */ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content within the toggle aligns slightly more inward than the alt_header
text. Can we adjust the styles to align the content with the header, similar to stripe's docs?
Also, just a heads up if we change any styles here, they will affect all elements on the page which have these classes. That means if the FAQs component is used on the same page as this expandable component, there might be conflicting styles.
It would be best to scope these styles specifically to this expandable component. Since the expandableContainer
class wraps all other elements. The easiest way to scope the styles to this component is by prefixing the classes in this css with .expandableContainer
, for example: .expandableContainer :local(.body)
. I'd recommend doing this for all css declarations in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much @JKarlavige ! made that change!
thanks so much @JKarlavige ! will review this 🙏 |
…abs/docs.getdbt.com into mwong-expandable-component
hey @JKarlavige and @nghi-ly - ready for rereview - thank you for the feedback! |
@mirnawong1 : feel free to merge! |
i'm merging this now @nghi-ly and @JKarlavige ! will look to see if its possible to add the lifecycle pill to this next week |
this pr creates completes this asana task: https://app.asana.com/0/1200099998847559/1206422502609164/f and creates an expandable component similar to notion toggles. it should:
we can use the following compoent to use it: