-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/gitlab integration page with a troubleshoot section #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of real quick comments/suggestions. Otherwise looks good!
website/docs/docs/dbt-cloud/cloud-configuring-dbt-cloud/connecting-gitlab.md
Outdated
Show resolved
Hide resolved
website/docs/docs/dbt-cloud/cloud-configuring-dbt-cloud/connecting-gitlab.md
Outdated
Show resolved
Hide resolved
…ting-gitlab.md Co-authored-by: Drew Banin <[email protected]>
website/docs/docs/dbt-cloud/cloud-configuring-dbt-cloud/connecting-gitlab.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - one more suggestion and then approved on my end.
Thanks Amy!
website/docs/docs/dbt-cloud/cloud-configuring-dbt-cloud/connecting-gitlab.md
Outdated
Show resolved
Hide resolved
…ting-gitlab.md Co-authored-by: Drew Banin <[email protected]>
Works for me! It's hard to write about an error that you didn't see yourself 😓 |
@drewbanin I think I need approval from you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
┏┓
┃┃╱╲ In this
┃╱╱╲╲ house
╱╱╭╮╲╲ we merge
▔▏┗┛▕▔ helpful docs PRs
╱▔▔▔▔▔▔▔▔▔▔╲
╱╱┏┳┓╭╮┏┳┓ ╲╲
▔▏┗┻┛┃┃┗┻┛▕▔
This is geared toward adding in a troubleshooting section for the GitLab page since this integration is very different from the Github one. I added in two issues that I noticed that has come up.