Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/gitlab integration page with a troubleshoot section #470

Merged
merged 5 commits into from
Nov 25, 2020

Conversation

amychen1776
Copy link
Collaborator

This is geared toward adding in a troubleshooting section for the GitLab page since this integration is very different from the Github one. I added in two issues that I noticed that has come up.

Copy link
Collaborator

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of real quick comments/suggestions. Otherwise looks good!

Copy link
Collaborator

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - one more suggestion and then approved on my end.

Thanks Amy!

@amychen1776
Copy link
Collaborator Author

amychen1776 commented Nov 24, 2020

Ok - one more suggestion and then approved on my end.

Works for me! It's hard to write about an error that you didn't see yourself 😓

@amychen1776
Copy link
Collaborator Author

@drewbanin I think I need approval from you :)

Copy link
Collaborator

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

┏┓
┃┃╱╲ In this
┃╱╱╲╲ house
╱╱╭╮╲╲ we merge
▔▏┗┛▕▔ helpful docs PRs
╱▔▔▔▔▔▔▔▔▔▔╲
╱╱┏┳┓╭╮┏┳┓ ╲╲
▔▏┗┻┛┃┃┗┻┛▕▔

@amychen1776 amychen1776 merged commit 623fc1b into current Nov 25, 2020
@amychen1776 amychen1776 deleted the update/gitlab_page branch November 25, 2020 14:06
nghi-ly pushed a commit that referenced this pull request May 2, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants