Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote wildcard #465

Closed
wants to merge 1 commit into from
Closed

Quote wildcard #465

wants to merge 1 commit into from

Conversation

max-sixty
Copy link

Description & motivation

At least on my shell — the * wildcard needs to be quoted to avoid the shell attempting to expand it. Or are others' shells different? (very possible!)

To-do before merge

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

@clrcrl
Copy link
Contributor

clrcrl commented Nov 19, 2020

Hmm I think this is a zsh vs bash difference, I'm not sure which is more popular @jtcohen6, do you have a sense?

@max-sixty
Copy link
Author

It does work on bash! I'm using fish, which is niche enough that I could understand closing this — your call.

The single quoting is never functionally worse, though maybe aesthetically so.

@annafil
Copy link
Contributor

annafil commented Jun 16, 2021

Hey there @max-sixty! Thanks for putting thought into this one and sorry we dropped the ball on this thread. I suspect we have more than this one example in the docs, and I'd rather not ask you to go find them and change them all :)

What do you think about creating a section on the FAQ instead to help others discover this if they run into a similar issue? You can check out this folder for examples. I think you just need to check in a .md file in the right format, and it will show up. ✨

In the meantime, I'll close out this PR but I'll be here to 👍 the next one :) And if you don't hear from anyone after a few days, feel free to nudge me in the Community slack 🙇‍♀️

@annafil annafil closed this Jun 16, 2021
nghi-ly pushed a commit that referenced this pull request May 2, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants