Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git master to git main in tutorial #443

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

comaraDOTcom
Copy link
Contributor

@comaraDOTcom comaraDOTcom commented Nov 5, 2020

Just noticed that the git push should push to the main branch of a new repo now as references to a master branch are no longer used by Github.

Description & motivation

I was going through the tutorial and noticed there is a reference to

$ git push -u origin master

which could be confusing to people who are new to git since git now uses main instead of master. I propose we change it to the following.

$ git push -u origin main

To-do before merge

Pre-release docs

Is this change related to an unreleased version of dbt?

  • Yes: please
    • update the base branch to next
    • add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
    • add links to the "New and changed documentation" section of the latest Migration Guide
  • No: please ensure the base branch is current
  • Unsure: we'll let you know!

Checklist

If you added new pages (delete if not applicable):

  • The page has been added to website/sidebars.js
  • The new page has a unique filename

If you removed existing pages (delete if not applicable):

  • The page has been removed from website/sidebars.js
  • An entry has been added to _redirects

Just noticed that the git push should push to the main branch of a new repo now as references to a master branch are no longer used by Github.
@comaraDOTcom comaraDOTcom changed the title Update 2b-create-a-project-dbt-cli.md Update git master to git main in tutorial Nov 5, 2020
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting this.

@VersusFacit VersusFacit merged commit 02259e8 into dbt-labs:current Nov 6, 2020
@comaraDOTcom comaraDOTcom deleted the patch-1 branch November 6, 2020 09:57
nghi-ly pushed a commit that referenced this pull request May 2, 2024
REPO SYNC - Public to Private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants