Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use cases for 'local' packages #4048

Merged
merged 9 commits into from
Sep 8, 2023

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Sep 8, 2023

Context: dbt-labs/dbt-core#8541 (comment)

What are you changing in this pull request and why?

There are multiple legitimate use cases for 'local' packages, beyond the one that's currently documented — especially as we see more multi-project setups.

@jtcohen6 jtcohen6 requested a review from a team as a code owner September 8, 2023 10:21
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 9d4f491
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64fb13617886e60008be8237
😎 Deploy Preview https://deploy-preview-4048--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the content Improvements or additions to content label Sep 8, 2023
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Sep 8, 2023
@mirnawong1
Copy link
Contributor

hey @jtcohen6 , thanks for opening this up and clarifying! I've left some suggestions for clarity and readability - if you're happy with them, i can go ahead and commit/merge

@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Sep 8, 2023

Thank you @mirnawong1! I took a quick look over your suggestions - I'm happy with all of them!

@mirnawong1
Copy link
Contributor

thanks so much for the quick response @jtcohen6 , I'll get these committed + merged for you ✨

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1
Copy link
Contributor

Screenshot 2023-09-08 at 13 33 11

@mirnawong1 mirnawong1 merged commit ae63f53 into current Sep 8, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the jerco/update-local-packages branch September 8, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants