Update use cases for 'local' packages #4048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
github-actions
bot
added
the
size: small
mirnawong1
reviewed
Sep 8, 2023
mirnawong1
reviewed
Sep 8, 2023
mirnawong1
reviewed
Sep 8, 2023
mirnawong1
reviewed
Sep 8, 2023
mirnawong1
reviewed
Sep 8, 2023
mirnawong1
reviewed
Sep 8, 2023
|
hey @jtcohen6 , thanks for opening this up and clarifying! I've left some suggestions for clarity and readability - if you're happy with them, i can go ahead and commit/merge |
|
Thank you @mirnawong1! I took a quick look over your suggestions - I'm happy with all of them! |
|
thanks so much for the quick response @jtcohen6 , I'll get these committed + merged for you ✨ |
mirnawong1
reviewed
Sep 8, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dbt-labs/dbt-core#8541 (comment)
What are you changing in this pull request and why?
There are multiple legitimate use cases for 'local' packages, beyond the one that's currently documented — especially as we see more multi-project setups.