Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add relation examples for {{this}} #4011

Merged
merged 24 commits into from
Sep 19, 2023
Merged

add relation examples for {{this}} #4011

merged 24 commits into from
Sep 19, 2023

Conversation

mirnawong1
Copy link
Contributor

this pr expand options for {{this}} and use keywords/related docs to improve linkage. This was flagged by @alison985 in the dbt slack community.

Resolves #3939

@mirnawong1 mirnawong1 requested a review from a team as a code owner September 4, 2023 11:41
@netlify
Copy link

netlify bot commented Sep 4, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit ef4e099
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64fee61c2390690008a41c46
😎 Deploy Preview https://deploy-preview-4011--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mirnawong1 mirnawong1 changed the title expand options for {{this}} add exaples for {{this}} Sep 4, 2023
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Sep 4, 2023
@mirnawong1 mirnawong1 changed the title add exaples for {{this}} add relation examples for {{this}} Sep 4, 2023
patkearns10
patkearns10 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@patkearns10 patkearns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌵

@mirnawong1
Copy link
Contributor Author

going to chat with joel about this tues

@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 9:10am

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: medium This change will take up to a week to address labels Sep 15, 2023
joellabes
joellabes requested changes Sep 16, 2023
View reviewed changes
website/docs/reference/dbt-classes.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-jinja-functions/source.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-classes.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-jinja-functions/ref.md Outdated Show resolved Hide resolved
website/docs/reference/dbt-jinja-functions/this.md Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor Author

hey @joellabes , thanks for your amazing feedback! I've applied all your suggs - can you give it another look? preview here

joellabes
joellabes approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mirnawong1 mirnawong1 merged commit 84b0927 into current Sep 19, 2023
8 checks passed
@mirnawong1 mirnawong1 deleted the mwong-add-this-options branch September 19, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

@patkearns10 patkearns10 patkearns10 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand options for {{this}} and use keywords/related docs to improve linkage
3 participants
@mirnawong1 @joellabes @patkearns10