Update SL-MF tutorial for proper expr usage and BigQuery #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an expression in a dimension name is not valid, and the expression is not valid for BigQuery
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
mirnawong1
reviewed
Sep 11, 2023
...ocs/guides/best-practices/how-we-build-our-metrics/semantic-layer-3-build-semantic-models.md
Outdated
Show resolved
Hide resolved
…mantic-layer-3-build-semantic-models.md
mirnawong1
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
hey @tromsky , thanks for opening this pr to clarify that - def makes sense and really appreciate your contribution ✨ I'll get this merged for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an expression in a dimension name is not valid, and the expression is not valid for BigQuery
What are you changing in this pull request and why?
I only have access to BigQuery for doing tutorial lessons and walkthroughs as that was the adapter used in one of the original quickstart guides for dbt Core. The
date_truncfunction used in this guide is not valid for BigQuery so I've included a comment with the BigQuery version.Also, as I was trying to follow along, I was getting errors due to the use of a function call within the
nameparam of a dimension (forordered_at). I set thenametoordered_atand moved the function call into anexprparam and that seemed to work so I'm including it here.Checklist