-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update not_null_proportion
data test to use cross-database type_numeric()
macro
#800
Update not_null_proportion
data test to use cross-database type_numeric()
macro
#800
Conversation
Signed-off-by: Henri Blancke <[email protected]>
Signed-off-by: Henri Blancke <[email protected]>
@joellabes would it be possible for you to take a look at his? Let me know if anything needs changing. Thanks! |
@henriblancke would you try to fix conflicts and try again. I hope someone will merge it. |
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
not_null_proportion
data test to use cross-database type_numeric()
macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this @henriblancke !
The pre-existing tests are passing, so this looks good to me 👍
resolves #553
This is a:
Description & motivation
Checklist
star()
source)limit_zero()
macro in place of the literal string:limit 0
dbt.type_*
macros instead of explicit datatypes (e.g.dbt.type_timestamp()
instead ofTIMESTAMP