Limit columns selected in expression_is_true
if failures not stored.
#686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #683
resolves #
This is a:
All pull requests from community contributors should target the
main
branch (default).Description & motivation
As discussed in #683, the default behaviour for the
expression_is_true
test is toSELECT *
which is expensive in some engines. The change instead doesSELECT 1
unlessshould_store_failures()
is true, resulting in faster and cheaper tests.Checklist
I followed guidelines to ensure that my changes will work on "non-core" adapters by:Not applicabledispatching any new macro(s) so non-core adapters can also use them (e.g. thestar()
source)using thelimit_zero()
macro in place of the literal string:limit 0
usingdbt.type_*
macros instead of explicit datatypes (e.g.dbt.type_timestamp()
instead ofTIMESTAMP
I have updated the README.md (if applicable)Not applicable