Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the deprecated identifier macro #672

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Delete the deprecated identifier macro #672

merged 2 commits into from
Sep 19, 2022

Conversation

miles170
Copy link
Contributor

resolves #669

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Remove deprecated identifier() that hasn't been used in a long time.

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@miles170 miles170 force-pushed the remove-deprecated-identifier-macro branch from 7fc1088 to 58df17a Compare September 15, 2022 06:18
@miles170 miles170 changed the title Delete the deprecated identifier Delete the deprecated identifier macro Sep 15, 2022
@miles170 miles170 force-pushed the remove-deprecated-identifier-macro branch from 58df17a to d2d1061 Compare September 15, 2022 06:19
@miles170 miles170 force-pushed the remove-deprecated-identifier-macro branch from d2d1061 to b00aaa7 Compare September 19, 2022 04:20
@joellabes joellabes changed the base branch from main to utils-v1 September 19, 2022 04:21
joellabes
joellabes approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this one's pretty open and shut 😂

@joellabes joellabes merged commit f612170 into dbt-labs:utils-v1 Sep 19, 2022
@miles170 miles170 deleted the remove-deprecated-identifier-macro branch September 19, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete the deprecated identifier macro
2 participants
@miles170 @joellabes