Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize yml indentation under the 'models:' line on the README #613

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

leoebfolsom
Copy link
Contributor

@leoebfolsom leoebfolsom commented Jun 21, 2022

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

The yml indentation in the README is inconsistent. As someone who is not a yml expert but tries to stay consistent, wants my team to be consistent, and aspires to mostly get my yml indentation right on the first go, it is confusing to see inconsistency in the README.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt_utils.type_* macros instead of explicit datatypes (e.g. dbt_utils.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@leoebfolsom
Copy link
Contributor Author

Question for the team: seeing as this is only an update to the README, do I need to:

  • Update the CHANGELOG?
  • Create an issue?
  • Do anything else?

Thank you!

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this indentation, @leoebfolsom ! 🙌

No need to open an issue or update the CHANGELOG.

Thanks again for getting this buttoned up.

@dbeatty10 dbeatty10 merged commit ee7f53a into dbt-labs:main Jun 21, 2022
@leoebfolsom leoebfolsom deleted the readme-yml-indentation branch June 21, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants