Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional testing #588

Merged
merged 36 commits into from
May 13, 2022
Merged

Functional testing #588

merged 36 commits into from
May 13, 2022

Conversation

dbeatty10
Copy link
Contributor

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery* (caveat: dateadd test is skipped currently)
    • Postgres
    • Redshift
    • Snowflake
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Description & motivation

Followed the provided pattern for functional testing for all cross-database macros.

See:

jtcohen6 and others added 30 commits May 4, 2022 00:39
@jtcohen6
Initial functional testing
962f5ae
@dbeatty10
Skip BigQuery dateadd for now
b5b23f9
@dbeatty10
Split into one fixture and test per cross-database macro
551c1c8
@dbeatty10
Move the skip decorator
d59dac1
@dbeatty10
Scaffolding for fixtures and tests
da58f27
@dbeatty10
Functional tests for any_value macro
3860605
@dbeatty10
Remove TODO
7bdaa49
@dbeatty10
Functional tests for bool_or macro
2f17185
@dbeatty10
Functional tests for concat macro
171a8e6
@dbeatty10
Functional tests for date_trunc macro
ce3bff2
@dbeatty10
Functional tests for hash macro
8a9cb50
@dbeatty10
Functional tests for last_day macro
10c845e
@dbeatty10
Functional tests for length macro
6f3320c
@dbeatty10
Functional tests for listagg macro
c3f6235
@dbeatty10
Functional tests for position macro
7204519
@dbeatty10
Functional tests for replace macro
d421350
@dbeatty10
Functional tests for right macro
1bac8c8
@dbeatty10
Functional tests for safe_cast macro
2521a6b
@dbeatty10
Functional tests for split_part macro
0c3d208
@dbeatty10
Missing newline
e11ccf0
@dbeatty10
Conform bool_or macro to actual/expected test pattern
71375c4
@dbeatty10
Conform any_value macro to actual/expected test pattern
d4cbc0d
@dbeatty10
Functional tests for current_timestamp macro
7e2ea34
@dbeatty10
Remove extraneous newline
de6e223
@dbeatty10
Functional tests for current_timestamp_in_utc macro
1820d76
@dbeatty10
Functional tests for cast_bool_to_text macro
e702f28
@dbeatty10
Functional tests for string_literal macro
ade997b
@dbeatty10
Functional tests for escape_single_quotes macro
6b78b23
@dbeatty10
Functional tests for except macro
1618379
@dbeatty10
Functional tests for intersect macro
2d386a2
@dbeatty10 dbeatty10 marked this pull request as ready for review May 13, 2022 20:33
@dbeatty10 dbeatty10 merged commit 46a3acc into main May 13, 2022
@jtcohen6 jtcohen6 mentioned this pull request Sep 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @jtcohen6