Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the seed node specifications under the seeds key #581

Merged
merged 1 commit into from
May 12, 2022

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented May 11, 2022

resolves #558

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

For our integration tests, we had our seeds under the models key in our YAML configuration. dbt will emit a warning for each case. The solution is very simple: just move it under the seeds key instead!

Note: this will leave any deprecation warnings in place when running integration tests. Those warning will remain until we fully remove that functionality within a major release that contains breaking changes.

Checklist

  • I have verified that these changes work in CI for all the main warehouses
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dbeatty10 dbeatty10 requested a review from jasnonaz May 11, 2022 15:34
@dbeatty10 dbeatty10 marked this pull request as ready for review May 11, 2022 15:34
Copy link
Contributor

@jasnonaz jasnonaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch thank you!

@dbeatty10 dbeatty10 merged commit 50f1d48 into main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings when executing integration tests
2 participants