Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upfront ask to dispatch new macros #377

Merged

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Jun 1, 2021

This is a:

  • bug fix PR with no breaking changes — please ensure the base branch is master
  • new functionality — please ensure the base branch is the latest dev/ branch
  • a breaking change — please ensure the base branch is the latest dev/ branch

Description & motivation

To get tsql-utils current with 0.6.5 (dbt-msft/tsql-utils#49), I had to disable many new tests that went with new macros. When undispatched macros are added to dbt-utils, it requires two PRs to get the new macro working with TSQL:

  1. a PR to dbt-utils to allow the new macro to be dispatched
  2. a PR to tsql-utils adding the shim logic for the new macro.

My proposal would be to strive for all new proposed macros to have dispatch logic before merging. The rationale being:

  • IIRC, releases can't be used for submodules, yet
  • submodules are how the shim packages (tsql-utils, spark-utils, presto-utils) import dbt-utils.

This makes it hard to selectively add new functionality to the shim packages without taking all commits to master

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Copy link
Contributor

@clrcrl clrcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in favor of calling this out, but have some feedback on where we put this

.github/pull_request_template.md Outdated Show resolved Hide resolved
@dataders dataders marked this pull request as ready for review June 1, 2021 17:25
@dataders dataders requested a review from clrcrl June 1, 2021 18:28
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swanderz, totally on board with this!

@jtcohen6 jtcohen6 merged commit 0e00fb5 into dbt-labs:master Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants