Upfront ask to dispatch new macros #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
master
dev/
branchdev/
branchDescription & motivation
To get tsql-utils current with
0.6.5
(dbt-msft/tsql-utils#49), I had to disable many new tests that went with new macros. When undispatched macros are added to dbt-utils, it requires two PRs to get the new macro working with TSQL:My proposal would be to strive for all new proposed macros to have dispatch logic before merging. The rationale being:
This makes it hard to selectively add new functionality to the shim packages without taking all commits to master
Checklist