PR - lowercase except values in star() (#403)

* PR - lowercase `except` values in star() resolves #402 * Update test_star.sql * Update CHANGELOG.md * Update test_star.sql Co-authored-by: jasnonaz <[email protected]>
dbt-labs · Aug 30, 2021 · 5abb160 · 5abb160
1 parent 1e52037
commit 5abb160
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 - Declare compatibility with dbt v0.21.0, which has no breaking changes for this package ([#398](https://github.com/fishtown-analytics/dbt-utils/pull/398))
 
+## Features
+
+- Allow user to provide any case type when defining the `exclude` argument in `dbt_utils.star()` ([#403](https://github.com/dbt-labs/dbt-utils/pull/403))
+
 
 # dbt-utils v0.7.0
 ## Breaking changes

diff --git a/integration_tests/models/sql/test_star.sql b/integration_tests/models/sql/test_star.sql
@@ -1,7 +1,4 @@
-
--- TODO : Should the star macro use a case-insensitive comparison for the `except` field on Snowflake?
-
-{% set exclude_field = 'FIELD_3' if target.type == 'snowflake' else 'field_3' %}
+{% set exclude_field = 'field_3' %}
 
 
 with data as (

diff --git a/macros/sql/star.sql b/macros/sql/star.sql
@@ -16,7 +16,7 @@
 
     {%- for col in cols -%}
 
-        {%- if col.column not in except -%}
+        {%- if col.column|lower not in except|lower -%}
             {% do include_cols.append(col.column) %}
 
         {%- endif %}