Add invocation env to user agent string #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
approved these changes
Jun 3, 2022
jtcohen6
commented
Jun 3, 2022
dbt/adapters/spark/connections.py
Outdated
| f"dbt-labs-dbt-spark/{dbt_spark_version} (Databricks)" # noqa | ||
| ) | ||
| dbt_invocation_env = os.getenv(DBT_INVOCATION_ENV) or "manual" | ||
| user_agent_entry = f"dbt-labs-dbt-spark/{dbt_spark_version} (Databricks) ({dbt_invocation_env})" # noqa |
There was a problem hiding this comment.
Integration tests don't like this!
Runtime Error
E ('HY000', "[HY000] [unixODBC][Simba][DriverSupport] (2021) Invalid character ')' found in user-agent comment. (2021) (SQLDriverConnect)")
@ueshin Any chance you could advise here? This is an ODBC user agent, maybe the two sets of parens aren't allowed?
There was a problem hiding this comment.
Yeah, seems like they are not allowed for now. I'm not sure it's a bug or expected, though.
How about using a different pattern like f"dbt-labs-dbt-spark/{dbt_spark_version} (Databricks; {dbt_invocation_env})"?
dataders
approved these changes
Jun 5, 2022
Merged
francescomucio
pushed a commit
to francescomucio/dbt-spark
that referenced
this pull request
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: databricks/dbt-databricks#106
Description
DBT_INVOCATION_ENVenvironment variable to the user agent, per Databricks' request (cc @ueshin @bilalaslamseattle)Checklist
This PR includes tests, or tests are not required/relevant for this PRCHANGELOG.mdand added information about my change to the "dbt-spark next" section.