Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ODBC driver connection type #116
Support for ODBC driver connection type #116
Changes from 8 commits
7ca029f
25bfc61
9366d2e
c2dc0fd
a18be08
165d83b
9db1e6d
95e0d72
534486e
f882e15
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I landed on
pip install dbt-spark[ODBC]
becausepyodbc
is the only python dep that I imagine will require OS dependencies. Also, I think this should line up with connection methods (thrift
,http
,odbc
), rather than connection locations (Databricks, etc..)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I buy it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, I think we might want to try moving
PyHive[hive]
as an extra instead of principal requirement, since it's only necessary for thehttp
connection method.Justification: we see some installation errors (e.g. #114) resulting from less-maintained dependencies exclusive to PyHive
Not something we need to do right now!