-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve run times for large projects by reusing connections by default #1109
Conversation
… based on client_session_keep_alive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging from earlier conversations, does this PR need a rework? I think I saw the spec may have changed to default to True
regardless here.
Slightly out of context, this is from you:
we will update the default on reuse_connections to be True
Just want to know target
Fair, I should have updated the PR body. After internal discussions, we determined that we only wanted to default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved barring addressing that print
issue left by @aranke since I was going to raise it too as well as double checking we don't need additional overriding on the profile generation tests (there are just so many of them!).
resolves #1082
Problem
Run times for large projects are taking a long time, in part due to the fact that we don't reuse connections by default. This problem is made worse when using Key Pair authorization as the RSA key needs to be validated every time a connection is created.
Solution
Update
reuse_connections
to a default ofTrue
if the user has not specifiedclient_session_keep_alive=True
.Checklist