enable overwriting old partitions with new config #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matt-winkler
commented
May 3, 2024
•
matt-winkler
commented
- A common use case for this type of work is backfilling historical data due to additional / incorrect records having been received or updated after the fact
- thus, it isn't reasonable to expect this to operate purely in a "roll forward" manner
- famous last words, but the change to enable this type of logic feels fairly light
- looking for initial feedback while working on additional integration tests
dbeatty10
reviewed
May 7, 2024
dbeatty10
reviewed
May 7, 2024
There was a problem hiding this comment.
Seems reasonable to me to overwrite partitions to achieve a historical backfill (due to additional / incorrect records having been received or updated after the fact, etc.).
This seems very much in the same spirit as the table materialization which does a good ol' "kill and fill".
dbeatty10
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.