Skip to content

Commit

Permalink
We no longer support static sql for metrics in the manifest, so don't…
Browse files Browse the repository at this point in the history
… try to show an empty code block (#435)

* Because we no longer support static sql for metrics in the manifest, we should not show an empty sql codeblock in dbt docs for metrics

* Add changelog entry

---------

Co-authored-by: Jeremy Cohen <[email protected]>
  • Loading branch information
marcodamore and jtcohen6 authored Jul 18, 2023
1 parent 2f9b8f9 commit 78cb73d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Docs-20230718-192422.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Docs
body: Remove static SQL codeblock for metrics
time: 2023-07-18T19:24:22.155323+02:00
custom:
Author: marcodamore
Issue: "436"
8 changes: 0 additions & 8 deletions src/app/docs/metric.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ <h1>
<li ui-sref-active='active'><a ui-sref="dbt.metric({'#': 'details'})">Details</a></li>
<li ui-sref-active='active'><a ui-sref="dbt.metric({'#': 'description'})">Description</a></li>
<li ui-sref-active='active' ng-show = "parentsLength != 0"><a ui-sref="dbt.metric({'#': 'depends_on'})">Depends On</a></li>
<li ui-sref-active='active'><a ui-sref="dbt.metric({'#': 'code'})">SQL</a></li>
</ul>
</div>
</div>
Expand Down Expand Up @@ -67,13 +66,6 @@ <h6>Depends On</h6>
</div>
</section>


<section class="section">
<div class="section-target" id="code"></div>
<div class="section-content">
<code-block versions="versions" default="default_version" language="language"></code-block>
</div>
</section>
</div>
</div>
</div>

0 comments on commit 78cb73d

Please sign in to comment.