Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9593: Validation of unit test parsing for incremental models #9769

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Mar 17, 2024

resolves #9593

Problem

Unclear error message when is_incremental override wasn't specified for a unit test

Solution

Add parse-time errors when:

  • unit testing an incremental model but not providing an override for is_incremental
  • unit testing an incremental model overriding is_incremental: true but NOT providing an input for this

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (2c1926c) to head (5fb241e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9769      +/-   ##
==========================================
+ Coverage   88.05%   88.09%   +0.03%     
==========================================
  Files         178      178              
  Lines       22487    22495       +8     
==========================================
+ Hits        19802    19817      +15     
+ Misses       2685     2678       -7     
Flag Coverage Δ
integration 85.48% <100.00%> (+0.03%) ⬆️
unit 61.79% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review March 17, 2024 12:08
@aranke aranke requested a review from a team as a code owner March 17, 2024 12:08
@aranke aranke requested a review from MichelleArk March 19, 2024 11:10
@aranke aranke merged commit c5eb6d7 into main Mar 20, 2024
58 checks passed
@aranke aranke deleted the fix_9593 branch March 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] parse-time validation when unit testing incremental model
2 participants