-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove erroneously added wildcard
method name
#9642
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @heysweet |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9642 +/- ##
==========================================
- Coverage 88.07% 88.02% -0.06%
==========================================
Files 178 178
Lines 22439 22438 -1
==========================================
- Hits 19764 19750 -14
- Misses 2675 2688 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I just signed the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing and fixing this @heysweet !
One more approval needed -- we'll need to get approval from an engineer on the Core team before this is merged.
resolves #9641
Problem
https://github.com/dbt-labs/dbt-core/pull/6599/files#diff-9aa4de7075574ef36d838665148e5858294fae6fd66c0eed1fcf2033a34ee84eR50 erroneously added a new key to the
MethodName
enum which is completely unused -- all wildcard operations are performed within other methods, specifically:Solution
Remove the unused key to avoid polluting the
MethodName
enum.Before
The behavior before this PR is not what we want:
After
The behavior after this PR is what we want:
Checklist