-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cache to SavedQueryConfig #9588
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9588 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 168 168
Lines 22208 22212 +4
=======================================
+ Hits 19531 19535 +4
Misses 2677 2677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes me so happy that the actual change only has to be 4 lines and everything else is tests. Looks great! 🚢
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4946 |
resolves #9540
Problem
SL needs us to support a cache property for SavedQuery
Solution
Add cache to SavedQueryConfig.
Checklist