Move SavedQuery data artifact to dbt/artifacts
#9460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9460 +/- ##
==========================================
+ Coverage 87.89% 87.96% +0.07%
==========================================
Files 164 165 +1
Lines 21967 21975 +8
==========================================
+ Hits 19307 19331 +24
+ Misses 2660 2644 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5 tasks
…ts` in artifacts
This is important because we want to move the `Export` class to artifacts. However, because it had functional parts we would have split it in half, with the data definition exists in artifacts and the functional specification defined in core. At first glance thats not problematic. However, the `SavedQuery` definition in artifacts would only be able to point at the data definition of `Export`, and then the function `SavedQuery` spec in core would have to override that with the functional `Export` definition that exists in core. This would make the inheritance rather wonky and confusing. This refactor simplifies thigs greatly because now we can move the entirety of `Export` to artifacts, and the core `SavedQuery` won't have to override anything.
Specifically the components in `contracts/graph/saved_queries.py` which are `Export`, `ExportConfig`, and `QueryParams` got moved to `artifacts/resources/v1/saved_query.py`. The moving of `Export` was made possible by the refactor in the previous commit.
If we had followed the general paradigm we've set, we would have split `DependsOn` into a data half and a functional half, with the data half going in artifacts. However, doing so overly complicates the work that we're doing. Additionally looking forward, we hope to simplify the `DependsOn` (as well as `MacroDependsOn`) to use `sets` instead of `lists`, thus allowing us to get rid of the fuctional part. We haven't done that refactor here because there is a reasonable amount of risk associated with such a change such that doign so should be it's own segement of work.
I debated about making this two commits. However I only realized we needed to also move `NodeVersion` when I was most the way through moving `RefArgs`, and instead of stashing, I just decided to due both. They're kind of inseparable anyways because it only makes sense to move `NodeVersion` if you move `RefArgs`, but you can't move `RefArgs` unless you also move `NodeVersion`. The two in one commit are still small enough that I'm okay with this.
QMalcolm
force-pushed
the
qmalcolm--9386-move-saved-query-to-dbt-artifacts
branch
from
8ff0769
to
44a1f11
Compare
QMalcolm
changed the title
SavedQuery data artifact to dbt/artifacts
MichelleArk
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
approved pending 🟢 CI, which should be fixed once this is rebased on main (& #9473 is merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9386
Problem
We are moving data artifacts to
dbt/artifactsin a piecewise fashion. We needed to moveSavedQueryas part of that.Solution
Moved data portion of
SavedQueryto dbt/artifacts (and all other classes that doing so required)Checklist