Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin dbt-common #9398

Merged
merged 2 commits into from
Jan 17, 2024
Merged

pin dbt-common #9398

merged 2 commits into from
Jan 17, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 17, 2024

resolves dbt-labs/dbt-common#8

Problem

PyPI doesn't allow pinning to github releases so we need to pin dbt-common to a PyPI release.

Solution

Pin dbt-common

Note: Blocked on releasing dbt-common to pypi prod right now

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jan 17, 2024
@emmyoop
Copy link
Member Author

emmyoop commented Jan 17, 2024

Failures are expected since I haven't released dbt-common yet!

core/setup.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (321031c) 86.98% compared to head (d38cb83) 86.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9398      +/-   ##
==========================================
- Coverage   86.98%   86.91%   -0.07%     
==========================================
  Files         187      187              
  Lines       24947    24947              
==========================================
- Hits        21699    21683      -16     
- Misses       3248     3264      +16     
Flag Coverage Δ
integration 84.29% <ø> (-0.14%) ⬇️
unit 63.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review January 17, 2024 21:55
@emmyoop emmyoop requested a review from a team as a code owner January 17, 2024 21:55
@emmyoop emmyoop merged commit dc47f6b into main Jan 17, 2024
51 checks passed
@emmyoop emmyoop deleted the er/dbt-common-pin branch January 17, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update dbt-core to ref specific release of dbt-common
2 participants