Move WritableManifest to dbt/artifacts #9377
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9377 +/- ##
==========================================
+ Coverage 86.96% 86.99% +0.03%
==========================================
Files 187 197 +10
Lines 25014 25035 +21
==========================================
+ Hits 21754 21780 +26
+ Misses 3260 3255 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
changed the title
MichelleArk
changed the title
|
Kicked off workflows in adapter repos to run integration tests against this branch: |
| """This overrides the "upgrade_schema_version" call in VersionedSchema (via | ||
| ArtifactMixin) to modify the dictionary passed in from earlier versions of the manifest.""" | ||
| manifest_schema_version = get_artifact_schema_version(data) | ||
| if manifest_schema_version <= 10: |
There was a problem hiding this comment.
Should this be <= 11? The current version is 12, right?
There was a problem hiding this comment.
It should be! Let me make sure I haven't clobbered anything during a merge...
There was a problem hiding this comment.
our latest released version is still v11: https://schemas.getdbt.com/
This also looks consistent with whats on main: https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/contracts/graph/manifest.py#L1730-L1732
I'm hesitant to bump this here because it will likely need additional testing & implementation. I'll open up an issue we can take on as part of the dbt/artifacts refactor
resolves #9378
resolves #9379
Problem
Moving the schema definition of WritableManifest is necessary to create/populate an upstream, standalone dbt/artifacts directory.
Solution
Checklist