Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package-lock file's bad indentation #9341

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Jan 5, 2024

resolves #9319

Problem

when dbt deps created package-lock file, yaml.safe_load didn't include indents.

packages:
- package: dbt-labs/dbt_utils
  version: 1.0.0
- package: calogica/dbt_date
  version: 0.8.1
sha1_hash: f2bef868041b4f03296151f8be2969fc320a781a

Solution

solve bad indentation using yaml.load (set Dumper dbtPackageDumper)

packages:
  - package: dbt-labs/dbt_utils
    version: 1.0.0
  - package: calogica/dbt_date
    version: 0.8.1
sha1_hash: f2bef868041b4f03296151f8be2969fc320a781a

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 5, 2024
@jx2lee jx2lee marked this pull request as ready for review January 5, 2024 15:45
@jx2lee jx2lee requested a review from a team as a code owner January 5, 2024 15:45
@jx2lee jx2lee requested a review from gshank January 5, 2024 15:45
@jx2lee jx2lee changed the title Fixed package-lock yaml's bad indentation Fix package-lock file's bad indentation Jan 5, 2024
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.13%. Comparing base (11cc71b) to head (5cfb1ea).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9341      +/-   ##
==========================================
+ Coverage   86.64%   88.13%   +1.48%     
==========================================
  Files         224      178      -46     
  Lines       27004    22480    -4524     
==========================================
- Hits        23398    19812    -3586     
+ Misses       3606     2668     -938     
Flag Coverage Δ
integration 85.51% <100.00%> (+1.92%) ⬆️
unit 62.74% <0.00%> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jx2lee
Copy link
Contributor Author

jx2lee commented Mar 17, 2024

@gshank
Could you please let me know when you might be able to review it?
Thank you in advance for your time and consideration.

@gshank gshank closed this Mar 18, 2024
@gshank gshank reopened this Mar 18, 2024
@gshank gshank merged commit 58344f4 into dbt-labs:main Mar 18, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3514] [Feature] Use formatting for package-lock.yml that passes yamlint linting checks
3 participants