-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move events only used by core to dbt/events #9326
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9326 +/- ##
==========================================
- Coverage 86.66% 86.64% -0.03%
==========================================
Files 221 221
Lines 26957 26969 +12
==========================================
+ Hits 23363 23368 +5
- Misses 3594 3601 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
resolves #9152
Problem
The common subdirectly is being moved to a separate repo (dbt-common) shortly. Currently most events are defined in common, regardless of their usage. A large chunk of these only have usage in core, and should be moved out of common to avoid increasing development overhead (coordinating across multiple repos) when making changes to events only used in core.
Solution
Audit which events defined in common are only used in core (and not by common or adapters), and move those definitions to core.
Checklist
Ensuring we haven't regressed on cyclical dependencies:
(also was keeping an eye out as I was changing import paths)