In build command run unit tests before models #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* init attempt of adding clean_up methods to basic and unique_id tests * swapping cleanup method drop of test_schema to unique_schema to test breakage on docs_generate test * moving the clean_up method down into class BaseDocsGenerate * remove drop relation for unique_schema * manually define alternate_schema for clean_up as not being seen as part of project_config * add changelog * remove unneeded changelog * uncomment line that generates new manifest and delete manifest our changes created * make sure the manifest test is deleted and readd older version of manifest.json to appease test * manually revert file to previous commit * Revert "manually revert file to previous commit" This reverts commit a755419.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #9273 +/- ##
===============================================================
+ Coverage 85.64% 86.90% +1.25%
===============================================================
Files 181 181
Lines 27274 27338 +64
===============================================================
+ Hits 23360 23758 +398
+ Misses 3914 3580 -334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterallenwebb
approved these changes
Dec 20, 2023
| @@ -30,7 +30,3 @@ services: | |||
| working_dir: /usr/app | |||
| depends_on: | |||
| - database | |||
|
|
|||
| networks: | |||
There was a problem hiding this comment.
Was this change intentional? What does it do?
There was a problem hiding this comment.
The "docker compose up -d database" doesn't work because it complains about it. Not sure what it did to start with.
1 task
gshank
added a commit
that referenced
this pull request
Jan 16, 2024
* Initial implementation of unit testing (from pr #2911) Co-authored-by: Michelle Ark <[email protected]> * 8295 unit testing artifacts (#8477) * unit test config: tags & meta (#8565) * Add additional functional test for unit testing selection, artifacts, etc (#8639) * Enable inline csv format in unit testing (#8743) * Support unit testing incremental models (#8891) * update unit test key: unit -> unit-tests (#8988) * convert to use unit test name at top level key (#8966) * csv file fixtures (#9044) * Unit test support for `state:modified` and `--defer` (#9032) Co-authored-by: Michelle Ark <[email protected]> * Allow use of sources as unit testing inputs (#9059) * Use daff for diff formatting in unit testing (#8984) * Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config (#9064) Co-authored-by: Michelle Ark <[email protected]> Fix #8652: Use seed value if rows not specified * Move unit testing to test and build commands (#9108) * Enable unit testing in non-root packages (#9184) * convert test to data_test (#9201) * Make fixtures files full-fledged members of manifest and enable partial parsing (#9225) * In build command run unit tests before models (#9273) --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Emily Rockman <[email protected]> Co-authored-by: Jeremy Cohen <[email protected]> Co-authored-by: Kshitij Aranke <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9128
Problem
In the build command we want to be able to run unit tests first, before the model it tests, and skip the model if a unit test fails.
For selection purposes we want to keep the graph with the unit tests depending on the model. But for running the build command we want the opposite.
Solution
There were two alternatives for a solution here, and both of them have difficulties.
The most natural would be to change the graph to have the unit tests before the model, but that would be very strange for selection semantics, so we would have to have two separate dags, one with unit tests after the model and another with unit tests before the model. We could have modified the selection dag to look like the required execution dag, but that would be fairly complicated since every unit test would have to be inserted as parent of the model and itself be a child of every one of the model's parents. There were also concerns about performance, since adding test_edges to the build dag made things slower, and this solution would have increased the size of the dag even more.
The other alternative, and the one that's implemented here, is to insert the execution of the unit tests in before the execution of the model. This requires some refactoring of the way we "run" the job_queue, and some somewhat inelegant hacking of the build code. But is probably easier to understand than the graph hacking solution and doesn't have the performance risks.
Checklist