Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feature/decouple-adapters-from-core #9240

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    2474722 View commit details
    Browse the repository at this point in the history
  2. merge

    colin-rogers-dbt committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    07743b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Configuration menu
    Copy the full SHA
    252e3e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    ff9d519 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    bf079b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3187ded View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    0935570 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5488dfb View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Configuration menu
    Copy the full SHA
    4da67bf View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Fix ensuring we produce valid jsonschema artifacts for manifest, cata…

    …log, sources, and run-results (#9155)
    
    * Drop `all_refs=True` from jsonschema-ization build process
    
    Passing `all_refs=True` makes it so that Everything is a ref, even
    the top level schema. In jsonschema land, this essentially makes the
    produced artifact not a full schema, but a fractal object to be included
    in a schema. Thus when `$id` is passed in, jsonschema tools blow up
    because `$id` is for identifying a schema, which we explicitly weren't
    creating. The alternative was to drop the inclusion of `$id`. Howver, we're
    intending to create a schema, and having an `$id` is recommended best
    practice. Additionally since we were intending to create a schema,
    not a fractal, it seemed best to create to full schema.
    
    * Explicity produce jsonschemas using DRAFT_2020_12 dialect
    
    Previously were were implicitly using the `DRAFT_2020_12` dialect through
    mashumaro. It felt wise to begin explicitly specifying this. First, it
    is closest in available mashumaro provided dialects to what we produced
    pre 1.7. Secondly, if mashumaro changes its default for whatever reason
    (say a new dialect is added, and mashumaro moves to that), we don't want
    to automatically inherit that.
    
    * Bump manifest version to v12
    
    Core 1.7 released with manifest v11, and we don't want to be overriding
    that with 1.8. It'd be weird for 1.7 and 1.8 to both have v11 manifests,
    but for them to be different, right?
    
    * Begin including schema dialect specification in produced jsonschema
    
    In jsonschema's documentation they state
    > It's not always easy to tell which draft a JSON Schema is using.
    > You can use the $schema keyword to declare which version of the JSON Schema specification the schema is written to.
    > It's generally good practice to include it, though it is not required.
    
    and
    
    > For brevity, the $schema keyword isn't included in most of the examples in this book, but it should always be used in the real world.
    
    Basically, to know how to parse a schema, it's important to include what
    schema dialect is being used for the schema specification. The change in
    this commit ensures we include that information.
    
    * Create manifest v12 jsonschema specification
    
    * Add change documentation for jsonschema schema production fix
    
    * Bump run-results version to v6
    
    * Generate new v6 run-results jsonschema
    
    * Regenerate catalog v1 and sources v3 with fixed jsonschema production
    
    * Update tests to handle bumped versions of manifest and run-results
    QMalcolm authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0ab954e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c03823f View commit details
    Browse the repository at this point in the history
  3. merge main

    colin-rogers-dbt committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    522e99e View commit details
    Browse the repository at this point in the history