Contract enforcement on temporary tables #8889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8889 +/- ##
===========================================
- Coverage 86.35% 64.58% -21.77%
===========================================
Files 177 177
Lines 26383 26385 +2
===========================================
- Hits 22784 17042 -5742
- Misses 3599 9343 +5744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gshank
approved these changes
Oct 25, 2023
emmyoop
commented
Oct 25, 2023
aranke
approved these changes
Oct 25, 2023
McKnight-42
approved these changes
Oct 25, 2023
emmyoop
force-pushed
the
er/8857-regression
branch
2 times, most recently
from
9233eb0
to
1562d22
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* add test * fix test * first pass with constraint error * add back column checks for temp tables * changelog * Update .changes/unreleased/Fixes-20231024-145504.yaml (cherry picked from commit 98310b6)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* add test * fix test * first pass with constraint error * add back column checks for temp tables * changelog * Update .changes/unreleased/Fixes-20231024-145504.yaml (cherry picked from commit 98310b6)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* add test * fix test * first pass with constraint error * add back column checks for temp tables * changelog * Update .changes/unreleased/Fixes-20231024-145504.yaml (cherry picked from commit 98310b6)
emmyoop
added
the
Team:Adapters
emmyoop
added a commit
that referenced
this pull request
Oct 26, 2023
* add test * fix test * first pass with constraint error * add back column checks for temp tables * changelog * Update .changes/unreleased/Fixes-20231024-145504.yaml (cherry picked from commit 98310b6) Co-authored-by: Emily Rockman <[email protected]>
emmyoop
added a commit
that referenced
this pull request
Oct 26, 2023
* add test * fix test * first pass with constraint error * add back column checks for temp tables * changelog * Update .changes/unreleased/Fixes-20231024-145504.yaml (cherry picked from commit 98310b6) Co-authored-by: Emily Rockman <[email protected]>
emmyoop
added a commit
that referenced
this pull request
Oct 26, 2023
* add test * fix test * first pass with constraint error * add back column checks for temp tables * changelog * Update .changes/unreleased/Fixes-20231024-145504.yaml (cherry picked from commit 98310b6) Co-authored-by: Emily Rockman <[email protected]>
5 tasks
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8896
Problem
Contract enforcement checks not happening during an incremental run.
Solution
Add contract checks back for temporary tables but keep skipping constraints.
Checklist