Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract enforcement on temporary tables #8889

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Contract enforcement on temporary tables #8889

merged 6 commits into from
Oct 25, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 24, 2023

resolves #8896

Problem

Contract enforcement checks not happening during an incremental run.

Solution

Add contract checks back for temporary tables but keep skipping constraints.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 24, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efa6339) 86.35% compared to head (9233eb0) 64.58%.
Report is 2 commits behind head on main.

❗ Current head 9233eb0 differs from pull request most recent head 1562d22. Consider uploading reports for the commit 1562d22 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8889       +/-   ##
===========================================
- Coverage   86.35%   64.58%   -21.77%     
===========================================
  Files         177      177               
  Lines       26383    26385        +2     
===========================================
- Hits        22784    17042     -5742     
- Misses       3599     9343     +5744     
Flag Coverage Δ
integration ?
unit 64.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 119 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop changed the title Er/8857 regression Contract enforcement on temporary tables Oct 25, 2023
@emmyoop emmyoop marked this pull request as ready for review October 25, 2023 14:03
@emmyoop emmyoop requested review from a team as code owners October 25, 2023 14:03
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning up my mess 😅

@emmyoop emmyoop force-pushed the er/8857-regression branch 2 times, most recently from 9233eb0 to 1562d22 Compare October 25, 2023 15:44
@emmyoop emmyoop merged commit 98310b6 into main Oct 25, 2023
81 of 97 checks passed
@emmyoop emmyoop deleted the er/8857-regression branch October 25, 2023 16:10
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
* add test

* fix test

* first pass with constraint error

* add back column checks for temp tables

* changelog

* Update .changes/unreleased/Fixes-20231024-145504.yaml

(cherry picked from commit 98310b6)
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
* add test

* fix test

* first pass with constraint error

* add back column checks for temp tables

* changelog

* Update .changes/unreleased/Fixes-20231024-145504.yaml

(cherry picked from commit 98310b6)
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
* add test

* fix test

* first pass with constraint error

* add back column checks for temp tables

* changelog

* Update .changes/unreleased/Fixes-20231024-145504.yaml

(cherry picked from commit 98310b6)
@emmyoop emmyoop added the Team:Adapters Issues designated for the adapter area of the code label Oct 26, 2023
emmyoop added a commit that referenced this pull request Oct 26, 2023
* add test

* fix test

* first pass with constraint error

* add back column checks for temp tables

* changelog

* Update .changes/unreleased/Fixes-20231024-145504.yaml

(cherry picked from commit 98310b6)

Co-authored-by: Emily Rockman <[email protected]>
emmyoop added a commit that referenced this pull request Oct 26, 2023
* add test

* fix test

* first pass with constraint error

* add back column checks for temp tables

* changelog

* Update .changes/unreleased/Fixes-20231024-145504.yaml

(cherry picked from commit 98310b6)

Co-authored-by: Emily Rockman <[email protected]>
emmyoop added a commit that referenced this pull request Oct 26, 2023
* add test

* fix test

* first pass with constraint error

* add back column checks for temp tables

* changelog

* Update .changes/unreleased/Fixes-20231024-145504.yaml

(cherry picked from commit 98310b6)

Co-authored-by: Emily Rockman <[email protected]>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3260] [Regression] Missing contract enforcement checks on temporary tables
4 participants