Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot success message to display "INSERT 0 1" (for example) instead of "success" #8524

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 30, 2023

resolves #7583

Problem

Incorrect message (changed from 1.3.4).

Solution

Save result.message in the event and use in constructing the message

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner August 30, 2023 19:13
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (f063e4e) 86.34% compared to head (95ea17f) 86.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8524      +/-   ##
==========================================
- Coverage   86.34%   86.34%   -0.01%     
==========================================
  Files         174      174              
  Lines       25531    25531              
==========================================
- Hits        22046    22045       -1     
- Misses       3485     3486       +1     
Flag Coverage Δ
integration 83.14% <100.00%> (-0.01%) ⬇️
unit 65.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/events/types_pb2.py 1.34% <ø> (ø)
core/dbt/task/snapshot.py 96.15% <ø> (ø)
core/dbt/events/types.py 98.63% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cla-bot cla-bot bot added the cla:yes label Aug 30, 2023
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gshank gshank merged commit d8e8a78 into main Aug 31, 2023
55 checks passed
@gshank gshank deleted the 7583-log_snapshot_result branch August 31, 2023 17:09
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8524-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8e8a78368882f3dae8efc25fdb8d287f5ebe4e8
# Push it to GitHub
git push --set-upstream origin backport-8524-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-8524-to-1.6.latest.

gshank added a commit that referenced this pull request Aug 31, 2023
gshank added a commit that referenced this pull request Aug 31, 2023
gshank added a commit that referenced this pull request Aug 31, 2023
gshank added a commit that referenced this pull request Aug 31, 2023
gshank added a commit that referenced this pull request Aug 31, 2023
gshank added a commit that referenced this pull request Aug 31, 2023
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a snapshot succeeds, LogSnapshotResult shows result.status when it should show result.message
2 participants