-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Semantic Models to DAG #7896
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
I think for partial parsing changing, semantic models is more like exposures or the old metrics, so I don't think you can just add it to the list of models/seeds/snapshots/analyses sections. Those files do processing that's SQL file based, and semantic models is not. Probably better to start by copy-and-pasting the "metrics" section and modifying. There's a bunch of duplication there which we should look at in a tech debt ticket eventually, but I'm sure we don't want to do that now... One big difference between sql file processing and schema file processing is that they use different file objects: SchemaSourceFile vs SourceFile, which have different fields and anything in a schema file needs the schema file processing code. Schema files store a dictionary representation of the schema file and reparse based on different section entries, and the SourceFile object doesn't contain any of the fields necessary to do that. |
Abandoned in favor of different approach. |
resolves #7800
Description
This PR links semantic models in to the DAG and ensures that changes to them are picked up by the partial parsing system.
Checklist
changie new
to create a changelog entry