Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semantic Models to DAG #7896

Closed
wants to merge 9 commits into from

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Jun 16, 2023

resolves #7800

Description

This PR links semantic models in to the DAG and ensures that changes to them are picked up by the partial parsing system.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner June 16, 2023 20:15
@cla-bot cla-bot bot added the cla:yes label Jun 16, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank
Copy link
Contributor

gshank commented Jun 19, 2023

I think for partial parsing changing, semantic models is more like exposures or the old metrics, so I don't think you can just add it to the list of models/seeds/snapshots/analyses sections. Those files do processing that's SQL file based, and semantic models is not. Probably better to start by copy-and-pasting the "metrics" section and modifying. There's a bunch of duplication there which we should look at in a tech debt ticket eventually, but I'm sure we don't want to do that now...

One big difference between sql file processing and schema file processing is that they use different file objects: SchemaSourceFile vs SourceFile, which have different fields and anything in a schema file needs the schema file processing code. Schema files store a dictionary representation of the schema file and reparse based on different section entries, and the SourceFile object doesn't contain any of the fields necessary to do that.

@peterallenwebb
Copy link
Contributor Author

Abandoned in favor of different approach.

@peterallenwebb peterallenwebb deleted the paw/ct-2651-semantic-models-in-dag branch May 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE] [CT-2651] Add SemanticModels and Metrics to the DAG
2 participants