Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Replaceable class #7844

Closed
wants to merge 5 commits into from
Closed

Remove Replaceable class #7844

wants to merge 5 commits into from

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jun 12, 2023

resolves #7802

Description

Remove the Replaceable class.

Checklist

@gshank gshank requested review from a team as code owners June 12, 2023 17:05
@cla-bot cla-bot bot added the cla:yes label Jun 12, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb
Copy link
Contributor

@gshank I think the failing test may be due to new uses of replaceable (booooo) added since you branched.

@jtcohen6
Copy link
Contributor

@gshank @peterallenwebb Is this still something we're looking to merge?

Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jan 15, 2024
Copy link
Contributor

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes stale Issues that have gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2652] Remove "Replaceable" class usage as much as possible
3 participants