Ensure that same_contract is called for state:modified #7283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
requested review from
peterallenwebb and
QMalcolm
and removed request for
ChenyuLInx
peterallenwebb
approved these changes
Apr 6, 2023
MichelleArk
approved these changes
Apr 6, 2023
emmyoop
pushed a commit
that referenced
this pull request
Apr 10, 2023
emmyoop
pushed a commit
that referenced
this pull request
Apr 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7282
Description
Breaking changes in a contract throws an error for state:modified. Since the comparison methods did not throw errors before, the node "same_contents" method did an "and" of the comparison methods, which will shortcircuit calling any other methods after a "False" is encountered. Explicitly call the "same_contract" method to ensure it's always called.
Checklist
changie newto create a changelog entry