Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-387: Stub materialized view as a materialization #7211
ADAP-387: Stub materialized view as a materialization #7211
Changes from 21 commits
9c40e87
19aec7b
cda0eb4
40379b3
37eb64f
65672a9
f794560
845d7a3
2b9faaa
158b9f9
3287562
eca26b8
f3faee2
e4c7005
53b4adc
88f6cdd
056a356
66754dc
0252ea3
fcc480d
345c2b2
caad12c
d6eee2d
60a5392
e9c423e
eeb0d3f
33a025b
703cff4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Referencing @Fleid's direction here for convenience:
This is going to vary by adapter; but I'd like to avoid creating versions of this materialization in adapters if possible. Hence I think we should adopt something like the strategies approach that we did with the incremental materialization. In other words, we have "replace" strategy, an "alter" strategy, a "refresh" strategy, etc. In some cases, those strategies may point to the same macros (e.g. create_materialized_view_as()); but that would allow maintainers to update just the piece that is specific to that platform without needing to maintain the rest of the materialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure this can actually exist outside of the if block above. For example, does
adapter.rename()
occur when you call it? Or does it just return the sql to do so? We're fine if it's the latter. But if it's the former, we'll do all the thing that happen immediately during the if block, and then do all the things that we return sql for during this phase. That may not be the right order.