[#4272] Move validator keyword argument in jinja 'config.get' to after default #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
force-pushed
the
config_get_params
branch
from
36a61f7
to
8a61a7c
Compare
jtcohen6
approved these changes
Nov 17, 2021
| @@ -3,6 +3,9 @@ | |||
| ### Features | |||
| - Avoid error when missing column in YAML description ([#4151](https://github.com/dbt-labs/dbt-core/issues/4151), [#4285](https://github.com/dbt-labs/dbt-core/pull/4285)) | |||
|
|
|||
| ### Fixes | |||
| - Allow specifying default in Jinja config.get with default keyword ([#4273](https://github.com/dbt-labs/dbt-core/issues/4273), [#4297](https://github.com/dbt-labs/dbt-core/pull/4297)) | |||
There was a problem hiding this comment.
Note to self to call out that this is technically a breaking change for anyone using config.get(arg1, arg2), and passing a validation function to arg2. I think that's a pretty small (or nonexistent) set of people
emmyoop
approved these changes
Nov 17, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4273
Description
The context provider code was wrapping the 'config.get' call in Jinja so that a default in the code required specifying the 'default=" keyword. This moves the order of the get validator param to after default so it's not necessary to specify the keyword.
Checklist
CHANGELOG.mdand added information about my change