New test configs #3392
Merged
New test configs #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git is terminally confused by this branch. Somehow a commit of mine (b952b70) seems to have gotten into this. I tried rebasing on develop because I like to look at a squashed commit to see all the changes and git couldn't do it. Could you make a clean branch and force push it? |
kwigley
force-pushed
the
feature/net-new-test-configs
branch
from
7c136b6
to
9e876cd
Compare
|
@gshank good call! Looks like I totally messed up a rebase at some point, should be in good shape now! |
gshank
approved these changes
May 26, 2021
core/dbt/parser/schemas.py
Outdated
| node.config['error_if'] = builder.error_if() | ||
| if builder.fail_calc() is not None: | ||
| node.unrendered_config['fail_calc'] = builder.fail_calc() | ||
| node.config['fail_calc'] = builder.fail_calc() |
There was a problem hiding this comment.
I'd prefer to see this in the builder as a method that just returns the configs. But we can leave that for later.
kwigley
force-pushed
the
feature/net-new-test-configs
branch
from
7da8c9f
to
1ed23b2
Compare
iknox-fa
reviewed
May 27, 2021
iknox-fa
reviewed
May 27, 2021
|
A few super minor details.. otherwise LGTM! |
7 tasks
kwigley
force-pushed
the
feature/net-new-test-configs
branch
2 times, most recently
from
cae0941
to
4157d02
Compare
Co-authored-by: Jeremy Cohen <[email protected]>
Co-authored-by: Jeremy Cohen <[email protected]>
kwigley
force-pushed
the
feature/net-new-test-configs
branch
from
4157d02
to
2adeb76
Compare
kwigley
force-pushed
the
feature/net-new-test-configs
branch
from
2adeb76
to
86637c8
Compare
This was referenced Jun 2, 2021
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* New test configs: where, limit, warn_if, error_if * update test task and tests * fix flake8 * Update core/dbt/parser/schemas.py Co-authored-by: Jeremy Cohen <[email protected]> * Update core/dbt/parser/schema_test_builders.py Co-authored-by: Jeremy Cohen <[email protected]> * respond to some feedback * add failures field * add failures to results * more feedback * add some test coverage * dev review feedback Co-authored-by: Jeremy Cohen <[email protected]> automatic commit by git-black, original commits: 2c40530
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* New test configs: where, limit, warn_if, error_if * update test task and tests * fix flake8 * Update core/dbt/parser/schemas.py Co-authored-by: Jeremy Cohen <[email protected]> * Update core/dbt/parser/schema_test_builders.py Co-authored-by: Jeremy Cohen <[email protected]> * respond to some feedback * add failures field * add failures to results * more feedback * add some test coverage * dev review feedback Co-authored-by: Jeremy Cohen <[email protected]> automatic commit by git-black, original commits: 2388330 2c40530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopened from #3336! (thanks @jtcohen6 )
resolves #3258, #3321
Description
Adds
fourfive new test configs:limit: Simple enough, templated out in the materialization. This is mostly a complement for dbt test --store-failures #3316where: The way I did this was unbelievably hacky—see the test cases for yourself—but it works, and in a way that should be backwards compatible with all existing schema/generic tests, without them needing to change any part of their SQL definition. (This config doesn't make sense for one-off tests.)warn_if,error_if: The user supplies a python-evaluable string (e.g.>=3,<5,==0,!=0) and dbt will compare the fail count/calc against it.!=0severity: A little tricky, but I actually think they work reasonably together. By default,severity: error, and dbt checks theerror_ifcondition first; if not error, then check thewarn_ifcondition; if the result meets neither, it passes the test. If the user setsseverity: warn, dbt will skip over theerror_ifcondition entirely and jump straight towarn_if.fail_calc: User-supplied fail_calc for tests #3321Possible follow up work
wherelogic in a special internal macro, so long as it's included in the schema test parsing context?Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.