add log-format flag (#1237)#1791
Merged
Merged
Conversation
drewbanin
approved these changes
Sep 27, 2019
drewbanin
left a comment
drewbanin
left a comment
Contributor
There was a problem hiding this comment.
one comment about the CLI flag but this broadly looks good to me!
|
|
||
| p.add_argument( | ||
| '--log-format', | ||
| choices=['text', 'json', None], |
Contributor
There was a problem hiding this comment.
do you think it would be clearer to use default instead of None?
Contributor
Author
There was a problem hiding this comment.
I don't think it matters much, but we can!
This was referenced May 19, 2026
Watcher: Surface watcher dbt 1.8+ requirement in the error message
astronomer/astronomer-cosmos#2704
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1237
Add a
--log-formatflag. It acceptstextandjsonas valid arguments. All dbt tasks should honor it, it formats the command's output as the specified format instead of the task's default.Tasks that use
print(dbt lsanddbt debug) are mostly not changed by this flag, though messages that go through the logger, such asdbt ls's stderr output, will be transformed.