-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit ArtifactWritten
event when artifacts are written
#10940
Open
QMalcolm
wants to merge
7
commits into
main
Choose a base branch
from
qmalcolm--emit-artifact-written-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QMalcolm
force-pushed
the
qmalcolm--emit-artifact-written-events
branch
from
October 30, 2024 13:30
22caa49
to
c47dbf1
Compare
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10940 +/- ##
==========================================
- Coverage 89.19% 89.16% -0.04%
==========================================
Files 183 183
Lines 23496 23517 +21
==========================================
+ Hits 20958 20968 +10
- Misses 2538 2549 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MichelleArk
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10937
Problem
We recently ran into an issue where the run_results.json artifact wasn't being written (#10934). One of the struggles when debugging was whether core was even trying to write out the artifact.
Solution
Emit an
ArtifactWritten
event whenever an artifact is writtenChecklist