Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent behavior change flag names + deprecation warnings #10063

Merged
merged 12 commits into from
May 1, 2024

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Apr 29, 2024

resolves #10062

Problem

Behavior change flags have inconsistent naming + use of the deprecations module for firing warnings.

Solution

Rename flags + use deprecations module, as described here (internal notion)

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Apr 29, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (1a9fb61) to head (e620796).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10063      +/-   ##
==========================================
- Coverage   88.15%   88.14%   -0.01%     
==========================================
  Files         181      181              
  Lines       22683    22700      +17     
==========================================
+ Hits        19996    20009      +13     
- Misses       2687     2691       +4     
Flag Coverage Δ
integration 85.46% <100.00%> (-0.01%) ⬇️
unit 62.34% <72.97%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtcohen6 jtcohen6 force-pushed the jerco/10062-consistent-behavior-change-flags branch 2 times, most recently from c7d8552 to 2d9f671 Compare April 29, 2024 12:30
@jtcohen6 jtcohen6 force-pushed the jerco/10062-consistent-behavior-change-flags branch from 2d9f671 to 252b8d5 Compare April 29, 2024 13:13
@jtcohen6 jtcohen6 marked this pull request as ready for review April 29, 2024 13:13
@jtcohen6 jtcohen6 requested a review from a team as a code owner April 29, 2024 13:13
Copy link
Contributor

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some non-functional changes -- added documentation, updated changelog entry, reformatted the generated protos, and made the world's tiniest refactor.

The actual core changes here look great, thank you!

@jtcohen6 jtcohen6 merged commit a36057d into main May 1, 2024
62 checks passed
@jtcohen6 jtcohen6 deleted the jerco/10062-consistent-behavior-change-flags branch May 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flags] Rename behavior change flags + add consistent deprecation warnings
2 participants