Make invocation contexts more reliable in testing scenarios. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterallenwebb
commented
Feb 6, 2024
| @@ -26,10 +26,23 @@ def env_secrets(self) -> List[str]: | |||
| _INVOCATION_CONTEXT_VAR: ContextVar[InvocationContext] = ContextVar("DBT_INVOCATION_CONTEXT_VAR") | |||
|
|
|||
|
|
|||
| def _reliably_get_invocation_var() -> ContextVar: | |||
There was a problem hiding this comment.
This ensures that the ContextVar is identified by name, which works around some fancy async stuff pytest does which cause this module to be loaded multiple times.
There was a problem hiding this comment.
Huh, nice discovery with this!
4 tasks
MichelleArk
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #52
Description
Pytest uses some fancy async mechanisms in a way that meant the ContextVar object used to implement InvocationContext access was sometime created more than once. These changes refer to the variable by name rather than object identity, in order to avoid that issue.
Checklist
changie newto create a changelog entry