Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow #15

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Add CI workflow #15

merged 5 commits into from
Jan 8, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 5, 2024

resolves #12

targetting copy-code-from-dbt-core since thats where the tests exist

testing, code quality and build are all separate. The build workflow is just a stub until we decide on the build tool. We can use it to both test the build works during regularly run CI as well as for the release process if needed.

Left to do

@emmyoop emmyoop changed the title Er/ci workflow Add CI workflow Jan 6, 2024
# TODO: how to validate here? we did dbt --version previously...
- name: "Check wheel distributions"
run: |
pip freeze
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps: pip freeze | grep dbt-common? it should return a non-zero exit code if no match is found. e.g.

❯ pip freeze | grep requests
❯ echo $?
1
❯ pip freeze | grep dbt-common
dbt-common @ file:///Users/michelleark/src/dbt-common
❯ echo $?
0

Copy link
Collaborator

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can look into adding additional checks (e.g. mypy) to the pre-commit config but that can be done on the base PR. Here are the dbt-semantic-interfaces checks for reference: https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/.pre-commit-config.yaml

@emmyoop
Copy link
Member Author

emmyoop commented Jan 8, 2024

Agree. The code quality check will just run anything we set up in the config so we can play with it on the other branch.

@emmyoop emmyoop merged commit db55c87 into copy-code-from-dbt-core Jan 8, 2024
6 checks passed
@emmyoop emmyoop mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants