Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Patch for dbt show for a model with a struct column containing a json datatype #974

Merged
colin-rogers-dbt merged 7 commits into from
Oct 23, 2023
Merged

Patch for dbt show for a model with a struct column containing a json datatype #974

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b93327
patch for --show with json
matt-winkler Oct 21, 2023
a5c9b8c
update matts handle in changelog
matt-winkler Oct 23, 2023
e49cfc0
Update dbt/adapters/bigquery/connections.py
matt-winkler Oct 23, 2023
a32baf1
add json struct functional test
colin-rogers-dbt Oct 23, 2023
30f817e
remove old change log
matt-winkler Oct 23, 2023
b01397e
add comment to test
colin-rogers-dbt Oct 23, 2023
8b6bd15
Merge remote-tracking branch 'origin/mwinkler/json-show-patch' into m…
colin-rogers-dbt Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20231021-154237.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Patch for json inline --show

@colin-rogers-dbt colin-rogers-dbt Oct 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you generated a second changelog instead of updating this one, you can just delete this file

time: 2023-10-21T15:42:37.406853-06:00
custom:
Author: matt.winkler@dbtlabs.com
Comment thread
matt-winkler marked this conversation as resolved.
Outdated
Issue: "972"
11 changes: 10 additions & 1 deletion dbt/adapters/bigquery/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import google.auth
import google.auth.exceptions
import google.cloud.bigquery
import google.cloud.bigquery as bigquery
import google.cloud.exceptions
from google.api_core import retry, client_info
from google.auth import impersonated_credentials
Expand Down Expand Up @@ -63,6 +63,15 @@
)


# Override broken json deserializer for dbt show --inline
def _json_from_json(value, _):
Comment thread
matt-winkler marked this conversation as resolved.
"""NOOP string -> string coercion"""
return json.loads(value)


bigquery._helpers._CELLDATA_FROM_JSON["JSON"] = _json_from_json


@lru_cache()
def get_bigquery_defaults(scopes=None) -> Tuple[Any, Optional[str]]:
"""
Expand Down