This repository was archived by the owner on Sep 2, 2025. It is now read-only.
remove _json_from_json patch#1061
Merged
Merged
Conversation
Contributor
|
@colin-rogers-dbt I converted this to a draft while we wait for the fix to go out in bigquery. |
mikealfare
approved these changes
Feb 8, 2024
Contributor
|
@colin-rogers-dbt Does this need to be backported? If so, please add it to the release ticket (and apply the backport labels of course). |
2 tasks
Contributor
|
This looks like it will fix #1101 also. We'd just want to add the following test case also: dbt show --inline 'select parse_json(null)' |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-1061-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b48ec89c1d10124dd31ebaf2e8c2f5aae4ec68a
# Push it to GitHub
git push --set-upstream origin backport-1061-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latestThen, create a pull request where the |
tatiana
added a commit
to astronomer/astronomer-cosmos
that referenced
this pull request
Apr 29, 2025
…xes (#1719) While the initial x.x.0 versions of dbt adapters may have compatibility issues with certain dependencies, I observed that these incompatibilities are progressively addressed in later patch releases. The issue reported in #1709 appears to stem from dbt-bigquery accessing a protected member `google.cloud.bigquery._helpers._CELLDATA_FROM_JSON`, which was removed in `google-cloud-bigquery 3.31.0`. This access I believe was introduced in [dbt-bigquery#974](dbt-labs/dbt-bigquery#974) and later removed in [dbt-bigquery#1061](dbt-labs/dbt-bigquery#1061), with the fix subsequently back-ported to the 1.7 series via [dbt-bigquery#1074](dbt-labs/dbt-bigquery#1074). Therefore, I believe that relying on the latest patch versions is a better approach to avoid such issues, rather than individually resolving discrepancies. This PR aligns with that strategy. closes: #1709 --------- Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
pankajkoti
added a commit
to astronomer/astronomer-cosmos
that referenced
this pull request
Apr 29, 2025
…xes (#1719) While the initial x.x.0 versions of dbt adapters may have compatibility issues with certain dependencies, I observed that these incompatibilities are progressively addressed in later patch releases. The issue reported in #1709 appears to stem from dbt-bigquery accessing a protected member `google.cloud.bigquery._helpers._CELLDATA_FROM_JSON`, which was removed in `google-cloud-bigquery 3.31.0`. This access I believe was introduced in [dbt-bigquery#974](dbt-labs/dbt-bigquery#974) and later removed in [dbt-bigquery#1061](dbt-labs/dbt-bigquery#1061), with the fix subsequently back-ported to the 1.7 series via [dbt-bigquery#1074](dbt-labs/dbt-bigquery#1074). Therefore, I believe that relying on the latest patch versions is a better approach to avoid such issues, rather than individually resolving discrepancies. This PR aligns with that strategy. closes: #1709 --------- Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove _json_from_json patch
addresses: #1055
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist