Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

remove _json_from_json patch#1061

Merged
colin-rogers-dbt merged 10 commits into
mainfrom
removeJsonOverride
Feb 20, 2024
Merged

remove _json_from_json patch#1061
colin-rogers-dbt merged 10 commits into
mainfrom
removeJsonOverride

Conversation

@colin-rogers-dbt
Copy link
Copy Markdown
Contributor

remove _json_from_json patch

addresses: #1055

docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt self-assigned this Dec 19, 2023
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner December 19, 2023 23:38
Comment thread dev-requirements.txt Outdated
@cla-bot cla-bot Bot added the cla:yes label Dec 20, 2023
@mikealfare mikealfare marked this pull request as draft January 30, 2024 21:30
@mikealfare
Copy link
Copy Markdown
Contributor

@colin-rogers-dbt I converted this to a draft while we wait for the fix to go out in bigquery.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review February 8, 2024 00:11
@mikealfare
Copy link
Copy Markdown
Contributor

@colin-rogers-dbt Does this need to be backported? If so, please add it to the release ticket (and apply the backport labels of course).

@dbeatty10
Copy link
Copy Markdown
Contributor

This looks like it will fix #1101 also.

We'd just want to add the following test case also:

dbt show --inline 'select parse_json(null)'

@colin-rogers-dbt colin-rogers-dbt merged commit 6b48ec8 into main Feb 20, 2024
@colin-rogers-dbt colin-rogers-dbt deleted the removeJsonOverride branch February 20, 2024 18:54
@github-actions
Copy link
Copy Markdown
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-1061-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6b48ec89c1d10124dd31ebaf2e8c2f5aae4ec68a
# Push it to GitHub
git push --set-upstream origin backport-1061-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-1061-to-1.7.latest.

tatiana added a commit to astronomer/astronomer-cosmos that referenced this pull request Apr 29, 2025
…xes (#1719)

While the initial x.x.0 versions of dbt adapters may have compatibility
issues with certain dependencies, I observed that these
incompatibilities are progressively addressed in later patch releases.
The issue reported in #1709 appears to stem from dbt-bigquery accessing
a protected member `google.cloud.bigquery._helpers._CELLDATA_FROM_JSON`,
which was removed in `google-cloud-bigquery 3.31.0`. This access I
believe was introduced in
[dbt-bigquery#974](dbt-labs/dbt-bigquery#974)
and later removed in
[dbt-bigquery#1061](dbt-labs/dbt-bigquery#1061),
with the fix subsequently back-ported to the 1.7 series via
[dbt-bigquery#1074](dbt-labs/dbt-bigquery#1074).
Therefore, I believe that relying on the latest patch versions is a
better approach to avoid such issues, rather than individually resolving
discrepancies. This PR aligns with that strategy.


closes: #1709

---------

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
pankajkoti added a commit to astronomer/astronomer-cosmos that referenced this pull request Apr 29, 2025
…xes (#1719)

While the initial x.x.0 versions of dbt adapters may have compatibility
issues with certain dependencies, I observed that these
incompatibilities are progressively addressed in later patch releases.
The issue reported in #1709 appears to stem from dbt-bigquery accessing
a protected member `google.cloud.bigquery._helpers._CELLDATA_FROM_JSON`,
which was removed in `google-cloud-bigquery 3.31.0`. This access I
believe was introduced in
[dbt-bigquery#974](dbt-labs/dbt-bigquery#974)
and later removed in
[dbt-bigquery#1061](dbt-labs/dbt-bigquery#1061),
with the fix subsequently back-ported to the 1.7 series via
[dbt-bigquery#1074](dbt-labs/dbt-bigquery#1074).
Therefore, I believe that relying on the latest patch versions is a
better approach to avoid such issues, rather than individually resolving
discrepancies. This PR aligns with that strategy.


closes: #1709

---------

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants