Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot column names #290

Merged
merged 19 commits into from
Sep 18, 2024
Merged

Snapshot column names #290

merged 19 commits into from
Sep 18, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 3, 2024

resolves #289

Problem

We don't allow configuring snapshot column names.

Solution

Add configuration of dbt_valid_to, dbt_valid_from, dbt_updated_at, and dbt_scd_id column names.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner September 3, 2024 19:54
@cla-bot cla-bot bot added the cla:yes label Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

mikealfare
mikealfare reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, a few points of clarification, and a few new features that will require a minor version bump. Otherwise it looks good.

dbt/adapters/base/impl.py Outdated Show resolved Hide resolved
dbt/include/global_project/macros/materializations/snapshots/snapshot.sql Show resolved Hide resolved
dbt/include/global_project/macros/materializations/snapshots/strategies.sql Show resolved Hide resolved
dbt/adapters/base/impl.py Show resolved Hide resolved
dbt/include/global_project/macros/materializations/snapshots/helpers.sql Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt merged commit db11adc into main Sep 18, 2024
11 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the snapshot_column_names branch September 18, 2024 22:27
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Sep 19, 2024
Merged
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Sep 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit left review comments

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare

@graciegoheen graciegoheen Awaiting requested review from graciegoheen

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring snapshot column names
5 participants
@gshank @mikealfare @graciegoheen @VersusFacit @colin-rogers-dbt