Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework record/replay to record at the database connection level. #244

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Jun 21, 2024

Problem

Our previous approach to recording DWH interaction short-circuited a large amount of our own code upon replay. This caused problems with replay behavior, and was also conceptually difficult to reason about.

Solution

Record and replay at a different level of abstraction, cleanly separating dbt code from 3rd party code.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@peterallenwebb peterallenwebb requested a review from a team as a code owner June 21, 2024 19:02
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt merged commit 6e50885 into main Jul 16, 2024
15 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the paw/record-at-connection branch July 16, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants