-
Notifications
You must be signed in to change notification settings - Fork 11
Updating to match current file path naming schemes. #29
Conversation
…ting seeds-path to yaml files
@McKnight-42 Thanks for catching the Any reason to prefer |
pytest_dbt_adapter/projects/base.yml
Outdated
@@ -1,14 +1,15 @@ | |||
name: base | |||
paths: | |||
seeds/base.csv: files.seeds.base | |||
data/base.csv: files.seeds.base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we go from data
to seeds
? CC @jtcohen6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did. I guess this works because Matt's also setting seed-paths: ['data']
below—that is, overriding the default value (seeds/
) to keep using the old name (data/
) instead. I'm wondering if there's a reason to prefer doing it that way, rather than just using the new default name (seeds/
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can change it back, we tried both, and I think got swapped around which was the newer of the name changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it back to seeds @jtcohen6 if you could please take a look and see if there are any other changes you think would make sense. please let me know.
rowcount: 10 | ||
added: | ||
rowcount: 20 | ||
seed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have a spacing issue (tabs/spaces maybe) where it it shows up as something is difference. Let's look at cleaning that up before merging. I can help tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leahwicz I think these spacing changes are fine for now. It makes this file consistent with other yaml files 👍 in this directory (other files use 4 space indent). We should probably stick to the default 2 spaces for all yaml files, but prefer consistency for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! @leahwicz, can you confirm this works with dbt-spark before merging?
pytest_dbt_adapter/projects/base.yml
Outdated
@@ -8,7 +8,7 @@ paths: | |||
dbt_project_yml: | |||
models: | |||
dbt_test_project: | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove these spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there, i believe latest commit does
rowcount: 10 | ||
added: | ||
rowcount: 20 | ||
seed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leahwicz I think these spacing changes are fine for now. It makes this file consistent with other yaml files 👍 in this directory (other files use 4 space indent). We should probably stick to the default 2 spaces for all yaml files, but prefer consistency for now.
Yep we are good to go here. Thanks @McKnight-42 |
making changes to match dbt-core test -> tests naming scheme and updating seeds-path to yaml files.
Issues: #dbt-labs/dbt-core#2659
fixes issues in files data_test_ephemerals.ym, and data_tests.yml to match dbt-core file naming scheme from test -> tests.
TO BE USED FOR versions 1.0.01b and up
-- Co-Author Kyle Wigley