This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
add dbt adapter integration test class #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwigley
force-pushed
the
feature/add-integration-test-tools
branch
from
b305ee5
to
33872d1
Compare
This was referenced Feb 3, 2021
|
closing this as we want to take a better approach here, simply pulling over code from dbt-core has unblocked dbt-spark tests, but it will introduce an ugly pattern that will make further testing with this plugin difficult to manage |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #12
This is the first pass for adding integration testing test cases to adapter plugins. This contains the same structure and API as test/integration/base.py in dbt, but without any references to specific adapter or profile types. Tested locally with dbt-postgres integration tests. I'll follow up with creating an example that sets up integration tests with an adapter plugin.