Skip to content

Conversation

dn1lk
Copy link

@dn1lk dn1lk commented Oct 2, 2025

Hello there!

With this pull request, I added support for generated fields and also changed the generation of drop constraints in MySQL according to the documentation.

This is my first pull request for an open source project - if I do anything wrong, I'm ready to correct it =)

Copy link
Contributor

@rabbiveesh rabbiveesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by and large looking good, tho i think the drop constraint fix should go in a separate PR (b/c i don't know mysql well enough to see what was originally wrong; i don't want that to hold up the generated stuff)

@dn1lk dn1lk requested a review from rabbiveesh October 5, 2025 22:39
@dn1lk dn1lk changed the title MySQL: support generated fields & fix drop constraint MySQL: support generated fields Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants